Skip to content

fix(e2e): replace external devcontainer image with own registry test container#223

Merged
skevetter merged 1 commit into
mainfrom
b979-23ea-ws-c-container-registry
May 5, 2026
Merged

fix(e2e): replace external devcontainer image with own registry test container#223
skevetter merged 1 commit into
mainfrom
b979-23ea-ws-c-container-registry

Conversation

@skevetter

@skevetter skevetter commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace all mcr.microsoft.com/devcontainers/base:ubuntu references in E2E tests with ghcr.io/devsy-org/test-images/base:ubuntu
  • Eliminates dependency on external Microsoft Container Registry which causes timeout flakes in CI
  • Updated 10 testdata JSON files and 2 Go test files with assertion string changes

@netlify

netlify Bot commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit c91693c
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f93f3528521400087f61a0

@github-actions github-actions Bot added the size/s label May 4, 2026
@coderabbitai

coderabbitai Bot commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 13 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bd371f4f-a5ea-4a2b-90b4-79be2a70d278

📥 Commits

Reviewing files that changed from the base of the PR and between 4465aa9 and c91693c.

📒 Files selected for processing (12)
  • e2e/tests/extends/extends.go
  • e2e/tests/extends/testdata/array-extends/.devcontainer/base.json
  • e2e/tests/extends/testdata/array-replace/.devcontainer/base.json
  • e2e/tests/extends/testdata/deep-merge/.devcontainer/base.json
  • e2e/tests/extends/testdata/multi-level/.devcontainer/grandparent.json
  • e2e/tests/extends/testdata/single-level/.devcontainer/base.json
  • e2e/tests/readconfiguration/readconfiguration.go
  • e2e/tests/readconfiguration/testdata-container-env/.devcontainer/devcontainer.json
  • e2e/tests/readconfiguration/testdata-host-requirements/.devcontainer/devcontainer.json
  • e2e/tests/readconfiguration/testdata-port-attributes/.devcontainer/devcontainer.json
  • e2e/tests/readconfiguration/testdata-port-range/.devcontainer/devcontainer.json
  • e2e/tests/readconfiguration/testdata/.devcontainer/devcontainer.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter marked this pull request as ready for review May 5, 2026 00:03
@skevetter
skevetter enabled auto-merge (squash) May 5, 2026 00:03
@skevetter
skevetter force-pushed the b979-23ea-ws-c-container-registry branch from adbf83f to c91693c Compare May 5, 2026 00:52
@skevetter
skevetter merged commit b4b1afa into main May 5, 2026
54 checks passed
@skevetter
skevetter deleted the b979-23ea-ws-c-container-registry branch May 5, 2026 01:53
This was referenced May 16, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skevetter